Difference between revisions of "Documentation Improvement"

From GnuCash
Jump to: navigation, search
(Prepare The Build Directory: mention README])
(Setting Up Your System: split in 2 subchapters)
Line 25: Line 25:
 
==Setting Up Your System==
 
==Setting Up Your System==
  
To begin changing the documentation, you will need to set up your system with the proper software. You will need the following software:
+
To begin changing the documentation, you will need to set up your system with the proper software.
 +
 
 +
===Required Software===
 +
You will need the following software:
 
* To manage the change sequence, you will install the ''git'' version control system. See [[Git]] for more on this.
 
* To manage the change sequence, you will install the ''git'' version control system. See [[Git]] for more on this.
 
* To edit the source files, you will need to have a ''text editor''. Any text editor will do, as long as it can save your files without extra markup.
 
* To edit the source files, you will need to have a ''text editor''. Any text editor will do, as long as it can save your files without extra markup.
Line 33: Line 36:
 
*** ''creation:'' the builtin PrintScreen of your OS or desktop environment,
 
*** ''creation:'' the builtin PrintScreen of your OS or desktop environment,
 
*** ''manipulation:'' [https://www.imagemagick.org ImageMagick] is suggested because it is used by <tt>/util/adjust-dpi.sh</tt>.
 
*** ''manipulation:'' [https://www.imagemagick.org ImageMagick] is suggested because it is used by <tt>/util/adjust-dpi.sh</tt>.
 +
 +
===Inital Steps===
 
* To stage your changes, you will need an appropriate directory structure. See [[Initializing_Documentation_Build_Environment]] for more.
 
* To stage your changes, you will need an appropriate directory structure. See [[Initializing_Documentation_Build_Environment]] for more.
 
* To check your changes, you will use the ''make'' utility to compile the documentation locally. See [[The_Make_Utility]] for more on using and installing make.
 
* To check your changes, you will use the ''make'' utility to compile the documentation locally. See [[The_Make_Utility]] for more on using and installing make.

Revision as of 14:36, 17 September 2018

These instructions describe the process to change the Tutorial & Concepts Guide and the Help manuals.

If you are interested in translating the documentation, you should read Translating the GnuCash Guide and Help, too.

Preface and Introduction -- What to expect

The documentation update process uses the same software management tools that are used for updating the program itself. This ensures that changes are made consistently and reliably. This includes using a version control system (VCS) to coordinate contributions from disparate sources, as well as using eXtended Markup Language (XML) for the actual edits. It also requires contributors to check their contributions for compatibility by compiling the documentation before final submission.

These aspects require that documentation contributors learn and use several specialized tools to engage the process.

The tools and the process are outlined in this page.

Any changes you make will be inserted into local copies of the source documentation files and subsequently transferred to the main documentation set. These source files use a special markup in XML to provide structure. Later in the process, the XML files are converted to other versions (HTML, PDF, etc.) for viewing. As a documentation support person, your task is to shepherd your modifications through all stages from start to finish.

At each stage, you must validate your changes to assure that they are both valid and have the intended effect, and you must address any errors or unexpected changes that are found.

Since your changes will be carried out by software, there is a difference determination process that identifies exactly what and where changes will be made. This process permits you to be sure that only what you intend will actually be installed. After your changes have been validated locally, you will submit your changes to the project either through a "patch," or by a git "pull request" (both of which will be explained later).

For quality control, any changes you submit will be reviewed by a developer before your changes become official. If everything is accepted without requiring further work, your changes will be applied to the main set of documentation by a developer and you will be notified of that action.

The above brief description outlines the general documentation update process.

It may be helpful to become familiar with the references given in the REFERENCES section below.

Setting Up Your System

To begin changing the documentation, you will need to set up your system with the proper software.

Required Software

You will need the following software:

  • To manage the change sequence, you will install the git version control system. See Git for more on this.
  • To edit the source files, you will need to have a text editor. Any text editor will do, as long as it can save your files without extra markup.
  • To illustrate your text with #Screenshots and Images, you can use
    • for diagrams: any SVG able drawing program like {Libre|Open}OfficeDraw,
    • for screenshots:
      • creation: the builtin PrintScreen of your OS or desktop environment,
      • manipulation: ImageMagick is suggested because it is used by /util/adjust-dpi.sh.

Inital Steps

With the proper tools in place, there are a number of additional steps to take to prepare your system. You will need to obtain a local copy of the files from the GnuCash repository, which is called cloning. The cloned copy is what you will work on. To actually begin editing, you must first obtain a copy of the full set of the most recent documentation. You can obtain a full set using git. Once you have all the documentation, you can make changes in any part of the documents that might need them. The most current documents can be seen at http://code.gnucash.org/docs/.

The Documentation Change Process

To write GnuCash documentation the following steps must be completed in the order given. When executing any command listed, do not use quotations of any sort around the commands.

N.B.: The instructions below are for a non-committer preparing a patch. If you have commit privileges in the gnucash-docs repository, the git commands you use will be somewhat different. Please see Git. If you're not familiar with using git, you'll find more details on basic commands and links to documentation there as well. You may prefer one of the many Git GUIs to the command-line instructions here, especially if you use Microsoft Windows.

Create a Bugzilla Documentation Bug

Create a bugzilla bug if one does not already exist. See Bugzilla for more.

Note the bug number. You will be listed as wanting to be notified any time there is an update to the bug. You can monitor it until it is confirmed and installed.

Update Your Local Copy

Cloning the documentation copies the most current version of the documentation to your local computer, where you will be able to make your edits. Since others could be making changes to the documentation at the same time you are, the GnuCash documentation process employs the git VCS to coordinate the disparate contributions. Git ensures that your changes and those of any others are incorporated efficiently into one final set of source files. See Git to learn about using git.

For simplicity, this page assumes the local repository will be in folder /home/$USER/code/gnucash-docs, but it can be wherever the user prefers.

First, change to your preferred local source code folder.

 cd /home/$USER/code

Next, use the git clone command to download a full set of documentation files from github to your own computer.

 git clone https://github.com/Gnucash/gnucash-docs gnucash-docs

This will copy the documentation to your computer into the folder gnucash-docs.

Prepare The Build Directory

In order to validate your changes later on, we need to set up a build directory. As it's typically a one-time set up it's recommended to do it early in the documentation update process.

This requires to run a few text commands.

First change to your documentation source folder. This page still assumes this folder to be /home/$USER/code/gnucash-docs.

cd /home/$USER/code/gnucash-docs

Next create a new directory in there:

mkdir build

This will be the build directory as referred to later on this page.

Next is to initialize the build system.

./autogen.sh
cd build
../configure [--with-mobi ...]

Note all the dots. They are all important. If the execution of autogen.sh or configure fails this usually means your system is missing a tool required for documentation validation. If you can't figure out the error message (which unfortunately is geared towards developers) it is time to read the README file in the top source directory or ask an experienced developer for guidance. The gnucash developers are following the gnucash-user mailing list or the #gnucash irc channel.

Note
configure has several options. You can query them with configure --help.

If no errors are reported, your environment is ready to start editing the documentation.

Identify Location for Changes

GnuCash stores documentation in one master sequence, but reformats the information in different ways for different platforms. When you build the documentation, you create a copy in final format. To make changes, you need to edit the local repository files, not the build directory files. Once you have located the correct source files, you must identify the passages that need to be changed. Your changes should roughly follow the GNOME Documentation Style Guide of the GNOME Documentation Project.

Read the documentation carefully to find exactly where your change belongs.

The English Help Manual source XML files are in

/home/$USER/code/gnucash-docs/help/C

The English Tutorial and Concepts Guide source XML files are in

/home/$USER/code/gnucash-docs/guide/C

The non-english files are in the corresponding locations with C replaced by a 2 character language code.

It may be useful to have either a printed copy or a PDF copy [3] of the documentation available for reference. The PDF is often useful, because it allows using FIND (ctrl-F) to search for key words. This can be important to assure yourself that you have covered the existing places in the documentation where the issue you are interested in has already had a mention or treatment.

Draft Your Changes

If your changes are few and easily formulated, you should be able to make your changes directly in the source XML files.

If your changes are more extensive, you may find it helpful to develop your ideas in a separate temporary text file. If you use this approach, you will need to insert your changes into the XML file(s) affected. Doing this might be easier by using a specific XML Editor. Additional resources for XML are listed in the References section for this step.

Note: Remember to edit the source files in the repository directories, not in the build directories. The various make commands (run from the build directories), will copy the files from the repository to the build directories.

The source documents are saved in XML - or to be more precise DocBook - code, so all changes need to follow those formatting rules. DocBook enforces strict rules about tags and markup, so be sure to make your changes fit the XML tags in the manner of the existing documentation.

Note
It is not necessary to use comments to denote the start or end of your source modifications. The version control system is used to track changes.

Conventions

Examples of commonly-used tags include: chapter, segment, sect1, sect2, orderedlist, list item, para and their corresponding closing tags.

  • You should also use the Definitions <!ENTITY ...> from the main file where ever possible.
  • Elements of the graphical user interface (GUI) should have the respective markup e.g.for a label: <guilabel>Accounts</guilabel>. A incomplete list of gui elements:
accel, guibutton, guiicon, guimenu, guimenuitem, guisubmenu, keycap, keycode, keycombo, keysym, menuchoice, mousebutton, shortcut.
See e.g. https://tdg.docbook.org/tdg/5.0/docbook.html

Adding or Removing Files

If you are adding or deleting an XML file, for example adding a new chapter or appendix, you also need to update files [guide|help]/[language]/gnucash-{guide|help}.xml and [guide|help]/[language]/Makefile.am, then rerun autogen.sh and ../configure.sh. There is no need to update Makefile.in as this is generated by running autogen.sh.

Note
If your update adds new modules to the full set of documentation, you should review all modules in the directory in which you are working (gnucash-docs/help/C or gnucash-docs/guide/C) to determine what changes,if any, need to be made to modules outside your original assessment in step 2.

You can find an introduction to DocBook in Creating DocBook Documents.

Validate Your Changes

xmllint (invoked by make check in the appropriate build directory or sub-directory) is used to test that your xml file has no syntax errors or incorrect references to internal sections. The program xmllint is part of the package libxml.

xmllint starts with the main file gnucash-{guide|help}.xml. The main file references the other xml files in the directory so all are checked.

In a Terminal, change directory to the place in the build directory structure where the changed modules are located:

For example, if you had downloaded the documentation files to a directory called /home/$USER/code/gnucash-docs and created a build directory called /home/$USER/code/gnucash-docs/build:

To validate all the guide xml files for only the C (English) language:

 cd /home/$USER/code/gnucash-docs/build/guide/C

To validate all the guide xml files for all languages:

 cd /home/$USER/code/gnucash-docs/build/guide

To validate all the guide and help xml files:

 cd /home/$USER/code/gnucash-docs/build

Then:

 make check

If there are any errors, fix them and repeat this step until no errors are found.

If you are unable to fix an XML error, then go to Mailing_Lists and subscribe to the developers email list gnucash-devel@gnucash.org. If you are not a subscriber, then your email will wait for the list manager to find the time to address emails received from non-subscribers and you will not receive replies from developers unless they explicitly copy you. Send an email to gnucash-devel@gnucash.org asking for help. Provide as much information as possible, including the results of the xmllint command (I.e. the output from make check).

If your module(s) are free of XML errors, then the command returns no errors or warnings (if running in a terminal) or an empty file (if redirecting output to a file).

Ensure Only Expected Changes Have Been Made

You should double check that there are no accidental changes to the documentation.

The following command will show any changes to unstaged files

 git diff

Git status will list all files with differences to the last commit, in categories staged, unstaged, and unknown to git but not matching an ignore pattern.

 git status

Proofread in HTML

After you have tested the integrity of the XML using xmllint (make check) and have verified that the difference file shows the correct changes, then the Guide or Help must be recreated in HTML and the results examined in your browser to verify that the online version appears and reads as expected.

Build the Guide or Help file in HTML. Use this command exactly as written in a terminal, from the appropriate directory within the build directory structure:

 cd [appropriate directory or sub-directory within the build directory structure]
 make html

The above make command will run xsltproc and use an XSL stylesheet (.../xsl/general-customization.xsl) to turn the raw input XML into the output HTML that comprises the online version of the Guide or Help.

The built html files with be placed in an automatically created directory, which if using the example directories will be:

 /home/$USER/code/gnucash-docs/build/<guide|help>/C/gnucash-<guide|help>

Review the results in your browser; if you need to make changes, do so, then check, rebuild and review again.

It's amazing how errors which are obscure in XML--everything is obscure in XML--become blindingly obvious when rendered in the browser. Look for spelling errors, formatting oddness, incomplete tags, and missing or incorrect entities.

To view the results in a web browser, in a file manager (or for Windows: Windows Explorer/File Explorer) double click on either:

 /home/$USER/code/gnucash-docs/build/help/C/gnucash-help/help.html

or

 /home/$USER/code/gnucash-docs/build/guide/C/gnucash-guide/index.html


Once your inspection shows that the online Guide/Help is now acceptable in all respects, you should make certain that the build directory and its contents are not included in any respect in your patch.

If you are using build as the name of your build subdirectory in your repository directory, as in this example, it is not necessary to remove the build directory as the <repository>/.gitignore file includes build*, so git will ignore it.

To remove the build directory structure, before building the patch, use this terminal command:

 rm -rf "/home/$USER/code/gnucash-docs/build"

Add Extra Files

Git automatically tracks changes to files it knows are part of the repository. However, if you have added any files that should be included in your commit (xml or others, for example, illustrations), add (stage) them with the command:

 git add path/to/file
 

Note: Do NOT add file(s) from your build directory structure.

Here is another way to check your changes. Unless you're a programmer, you're probably not well practiced at examining diffs. If you have touched several files, the first thing to check is

 git status -uno

The -uno tells it to show only the repository files affected by your changes; all of the build products are ignored. Of course, if you've made a new file, that's ignored too, so make sure that all of the files you worked on and only those files are in the list. You can add new files with

 git add path/to/new-file

and revert files that you didn't mean to change with

 git checkout path/to/ignored-file

Publish your Authorship

The first page, which can also be shown as About of the document is in the file gnucash-{guide|help}-C.omf. OMF means Open Media Framework. Add a maintainer section with your data and check the other items like the date, which also needs an update.

Add your name and email address to the file AUTHORS. Create a separate patch for this change and ask to apply this patch also on gnucash/DOCUMENTERS - in both maint and master branches. The AUTHORS file can usually be shown in the packet manager while gnucash/DOCUMENTERS is shown in GnuCashs About->Credits->Documenters

Commit Your Changes

Once you're satisfied with your changes, it's time to commit them. You can commit everything that's been changed with

git commit -a
(-a also causes git to notice and commit any deleted files)

or you can commit a few files at a time with

git add path/to/file
git commit

If you need to make further changes, you can update your commit instead of creating a new one with

 git commit -a --amend

But --amend should only be used as long, as you did not publish your commit by pushing it to some public github repository.

There are even finer-grained ways to pick out bits and pieces to group into a commit, but they're beyond the scope of this tutorial.

When you make a commit git will open a screen editor; which one depends on how you set your environment. The default on most Unixes is vi, but you can select a different one with the $EDITOR environment variable. Use the editor to make a good commit message. It should have a one-line (< 80 character) summary followed by a blank line, and a brief description of the change and its motivation. Don't get carried away here: If you need more than a couple of lines it should have been a smaller change.

The release announcement comes from commit messages, so include any information that should be passed on. You could even say This needs to be mentioned in the release announcement followed by the text you want in the announcement.

To add extra information to a previously pushed commit message, make some trivial change to a comment and write a commit message using the same subject line as the previous commit.

If required, you can check committed changes to a particular file with

 git log -p path/to/file

Create a Pull Request or a Patch

Once you have finalized your changes, you will notify the developer team of your changes, either by creating a pull request, or by creating and uploading a patch.

References to Supporting Technologies Used

[1] http://wiki.gnucash.org/wiki/Bugzilla
[2] https://github.com
[3] http://www.jedit.org/
[4] http://en.wikipedia.org/wiki/DocBook
[5] http://www.docbook.org/ DocBook: The Definitive Guide
Some Distributions have it as a package named like docbook-tdg.
[6] http://www.tldp.org/LDP/LDP-Author-Guide/html/tools-edit.html
[7] http://www.netlingo.com/tips/html-code-cheat-sheet.php
[8] http://wiki.gnucash.org/wiki/Git

Additional Information

Screenshots and Images

Screenshots and images for GnuCash documentation must be submitted in .png format or in .svg where applicable. It is better if you can use a theme similar to "Clearlooks" for Linux, in order to maintain consistency with existing images. The Clearlooks engine has been the default theme of GNOME 2 since version 2.12. The utility adjust-dpi.sh uses the following programs

  • identify from ImageMagick, a nice toolset to manipulate images or query their parameters,
  • awk from gawk
  • bc from bc.

Indexing

To add your image to the List of Figures at the start of the Help or Tutorial and Concepts Guide, put your screenshot in a figure tag, for example:

  <figure pgwide="1">
    <title>This is the text that will appear in the List of Figures</title>
    <screenshot>
      <mediaobject>
        <!-- insert the imageobjects here -->
        <caption><para>Optionally you can here add a longer description than in the title.
          If not required, remove the caption element.</para>
        </caption>
      </mediaobject>
    </screenshot>
  </figure>

Display and Print Targets

Screenshots and images added to the GnuCash documentation must fit two purposes: video display (e.g. online) and paper printing (pdf creation). Each has its own way of determining width:

video display defines image width limits in terms of pixels, while
print output sets limits on image size based on a ratio of image size and the image's dots per inch (dpi).

Because we do not want to shrink the image itself, but want limit the width of

image presentations on screen to 510px
and 14 cm on paper, we get 2 different cases for our entry:
width <= 510px
and insert
      <imageobject>
        <imagedata fileref="figures/Report_Screen.png" format="PNG"
                   srccredit="your name"></imagedata>
      </imageobject>
width > 510px
Use two <imageobject> tags, as shown below:
      <imageobject role="html">
        <imagedata fileref="figures/Help_Pref_AccntPeriod.png" format="PNG"
                   srccredit="your name" width="510px"></imagedata>
      </imageobject>
      <imageobject role="fo">
        <imagedata fileref="figures/Help_Pref_AccntPeriod.png" format="PNG"
                   srccredit="your name"></imagedata>
      </imageobject>
The "html" attribute refers to display presentation on screens (the width is limited to 510px), while the "fo" attribute refers to pdf printing.
Note
If the viewport area (width|depth) is specified, but no content area (contentwidth|contentdepth), docbook sets scalefit=1 resulting in zooming the image to viewportsize.

Now the image will fit on display and we can continue to adjust it for printing.

Adjusting an Image's Dots Per Inch

You must take another step to prepare a screenshot for print output: you must set the dots per inch (dpi) correctly. The dpi defines an image's dot density, and thus its overall quality; the higher the dpi, the better the printed image quality. The printing size, dpi and image pixel dimensions are in this relation:

size = pixels / dpi
So if you have a screenshot that is 800x560 pixels with a dpi of 80 you will have the screenshot in the pdf output displayed as 800/80 x 560/80 inches = 10 x 7 inches = 25 x 17.5 cm. (1 inch is about 2.5 cm). The available space in the A4 format pdf output is a maximum of about 15 cm, so you can resize the screenshot by changing its dpi (Note that the US Letter size paper is slightly wider than A4, so images scaled for A4 will also fit on US Letter size paper). Normally if you take a screenshot when the GnuCash window is almost at its minimum, the dpi will be set to 144, which for our example screenshot will result in a print size of:
800/144 x 560/144 inches = 14 x 10 cm 
This will stay inside the available areas.
If the screenshot you are going to add to documentation is wider than 850 pixels, you should increase the dpi above 144 so that its printed size remains less than 15 cm.
Individual
The dpi of an image be changed in one of two ways:
  1. Open the screenshot in an image editor (like The Gimp) and select Image->Print Size. In the dialog that opens, set the X and Y resolution to the desired dpi (check that the unit value is set to the desired value - normally pixels/in). Press "Ok" and save the image.
  2. A faster approach uses Imagemagick, a library for image manipulation. From a terminal window, issue the following command:
    convert -units PixelsPerInch -density DPI IN OUT
    
where DPI is the desired dpi value (e.g. 144), IN is the input image filename and OUT the output filename (that could be the same as IN).
All at once
Old Method
  1. To convert the dpi of a bunch of images do this from a terminal window:
    ls *.png > list
    for i in `cat list`; do convert -units PixelsPerInch -density 144 "$i" "$i"; done
    
    The first line creates the file "list" with a list of all png files in the current directory
    The second and third lines applies a dpi of 144 to all images listed in the "list" file
  2. Imagemagick lets you also see sizes and pixels per inch from the command line:
    identify -format "%w x %h %x x %y" IMAGE_NAME.FORMAT
    
New Method
For your convenience the bash script adjust-dpi.sh has been included in the gnucash-docs repository that automatically calculates and assigns the right value of dpi to a list of png files. It is stored in the util subdirectory of the repository. To use it open a command line and run the script from the proper figures directory. For example:
cd guide/pt/figures            # In the repo, NOT the build directory structure
../../../util/adjust-dpi.sh

Maintenance

In this section are collected all the standards used to work on documentation.

Text conventions

  • There are variable definitions in the main file, which must be used e.g. for future changes to revision numbers, gnucash-guide.xml defines variable vers-stable
<!ENTITY vers-stable "2.6.6">
and appendixa.xml uses this variable like
The process works on &vers-stable; datafiles, and ought to
  • All accounts named must be tagged with <emphasis>: e.g. <emphasis>Expenses:Tax</emphasis>
  • Hyphens and dashes:
To represent a negative number or subtraction:
The typographically correct symbol to use is − (U+2212, &minus;). The ASCII hyphen-minus - (U+002d) is commonly used and is also fine. Whichever you use, be consistent, at least on the whole page.
Examples:
Number negative 1 (−1): &minus;1
Formula GROSS_SALE − TOTALBUY: GROSS_SALE &minus; TOTALBUY
See http://www.thepunctuationguide.com/index.html for guidance on using English language punctuation, including &ndash; and &mdash;.
  • In the current state of this page there are many more. Have a look at the recently reworked chapters. If you have some free time, add them here.

Graphics conventions

all screenshots of the GnuCash windows must be captured under a GNOME Desktop environment with the following settings:

  • GNOME desktop environment
  • Clearlooks theme
  • text besides icon
  • font: Sans. 9 point for application and 11 point for window title